Fix first login failing session evaluation (#191)

* fix first login triggering early using '-k' option

* updated specialized Destreamer versions
This commit is contained in:
lukaarma 2020-07-23 21:48:10 +02:00 committed by GitHub
parent 3144014a34
commit 23b71d47d4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions

View file

@ -12,9 +12,11 @@ _(Alternative artwork proposals are welcome! Submit one through an Issue.)_
This release would not have been possible without the code and time contributed by two distinguished developers: [@lukaarma](https://github.com/lukaarma) and [@kylon](https://github.com/kylon). Thank you!
[Politecnico di Milano][polisite] students may want to use this fork over at https://github.com/SamanFekri/destreamer which is a specialized implementation of this project with automatic logon.
### Customized vesions
Another specialized implementation (for University of Pisa this time) is available at https://github.com/Guray00/destreamer-unipi.
- [Politecnico di Milano][polimi]: fork over at https://github.com/SamanFekri/destreamer
- [Università di Pisa][unipi]: fork over at https://github.com/Guray00/destreamer-unipi
- [Università della Calabria][unical]: fork over at https://github.com/peppelongo96/UnicalDown
## What's new
@ -163,4 +165,6 @@ Please open an [issue](https://github.com/snobu/destreamer/issues) and we'll loo
[node]: https://nodejs.org/en/download/
[git]: https://git-scm.com/downloads
[wsl]: https://github.com/snobu/destreamer/issues/90#issuecomment-619377950
[polisite]: https://www.polimi.it
[polimi]: https://www.polimi.it
[unipi]: https://www.unipi.it/
[unical]: https://www.unical.it/portale/

View file

@ -80,7 +80,7 @@ async function DoInteractiveLogin(url: string, username?: string): Promise<Sessi
remember the credentials or it could still prompt the user for a password */
}
await browser.waitForTarget((target: puppeteer.Target) => target.url().includes('microsoftstream.com'), { timeout: 150000 });
await browser.waitForTarget((target: puppeteer.Target) => target.url().endsWith('microsoftstream.com/'), { timeout: 150000 });
logger.info('We are logged in.');
let session: Session | null = null;